Fix: Remove duplicate import and improve type checking#1623
Merged
carlosmiei merged 1 commit intosammchardy:masterfrom Dec 10, 2025
Merged
Conversation
pcriadoperez
approved these changes
Dec 7, 2025
Collaborator
pcriadoperez
left a comment
pcriadoperez
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the contribution!
pcriadoperez
pushed a commit
to pcriadoperez/python-binance
that referenced
this pull request
Mar 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses two code quality issues found during codebase review:
Changes
OptionsDepthCacheManagerwas imported twice in binance/init.py (lines 13 and 16)type(ts_str) == intwithisinstance(ts_str, int)in helpers.py for better Python practicesWhy?
isinstance()is the Pythonic way to check types and respects inheritance, whiletype()comparison does notTesting